Define "_Row" and "_Column" in the registry #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the component registry system to support globally defined _Row and _Column components, while also improving display template resolution at the section level. The changes enable more flexible component rendering configurations through the registry.
Key changes:
- Made
nodesprop mandatory inOptimizelyGridSectionto prevent runtime errors - Added support for
_Rowand_Columnregistry lookups with fallback chain - Extended display template key resolution to check section-level composition keys
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/optimizely-cms-sdk/src/react/server.tsx | Enhanced grid section rendering to check registry for _Row/_Column components, made nodes required, and improved display template key resolution |
| test/test-website/src/components/with-display-templates.tsx | Added test display templates and component variants for rows/columns, removed console.log statements, and exported components for registry |
| test/test-website/src/app/preview/page.tsx | Added conditional check before logging error request query |
| test/test-website/src/app/preview/layout.tsx | Simplified by reusing root layout |
| test/test-website/src/app/en/layout.tsx | Registered new display templates and _Row/_Column components in the registry |
| test/test-website/src/app/all/[...slug]/layout.tsx | Simplified by reusing root layout |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
__test__/test-website/src/components/with-display-templates.tsx
Outdated
Show resolved
Hide resolved
__test__/test-website/src/components/with-display-templates.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohanPetersson
approved these changes
Oct 25, 2025
TRomesh
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
<OptimizelyGridSection>renders by searching in the component registry if there is any component defined as_Rowor_Column<OptimizelyGridSection>renders properly by making the propnodesmandatory<OptimizelyComponent>searches Display Template Keys when they are defined in the Section level